Rewrite activerecord/RUNNING_UNIT_TESTS.rdoc
#10601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,7 @@ | |||
| * Rewrite RUNNING_UNIT_TESTS.rdoc | |||
|
|
|||
|
Changelog reverted. |
|
Much improved, thank you! |
|
Could you squash your commits? |
| If you don't have the environment set make sure to read | ||
|
|
||
| http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#testing-active-record | ||
| If you don't have an environment in which to run tests, read |
There was a problem hiding this comment.
this could be simpler like If you don't have an environment for running tests maybe?
`RUNNING_UNIT_TESTS` is written in an unclear and confusing manner. This commit attempts to correct that. Thanks to zzak and vipulnsward for feedback.
|
Commits have been squashed, @rafaelfranca. Thanks for the feedback, @zzak and @vipulnsward. |
|
Thank you so much |
rafaelfranca
added a commit
that referenced
this pull request
May 15, 2013
Rewrite `activerecord/RUNNING_UNIT_TESTS.rdoc`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote
activerecord/RUNNING_UNIT_TESTS.rdocto acheive, in my opinion, a greater level of clarity. The file has been reorganized, a few explanations were expanded, and one of the external hyperlinks was changed.