Fix XmlMini different backends tests #10727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone have any comment about this? |
|
Can you give more info? Why is the test case currently "wrong"? |
|
ahh, make sense. @schneems the |
rafaelfranca
added a commit
that referenced
this pull request
Jun 15, 2013
Fix XmlMini different backends tests
rafaelfranca
added a commit
that referenced
this pull request
Jun 15, 2013
Fix XmlMini different backends tests
|
Broke the build. |
|
@pacoguzman could you please fix it? |
|
Yes, I'll do
|
|
@rafaelfranca should I open a new PR with the fix, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in some of the tests for each backend we're comparing the parsed result with the result of the default backend 'REXML' but the implementation of the helper method used to do that I think is wrong.
This PR fix that problem