Customizable form class #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! I need it right now. |
|
Applied thanks :) |
|
Will this patch be available on 3.0.x versions? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, button_to's generated form element is hard coded to having the class "button_to".
This is somewhat inconvenient when trying to hook forms for ajax trickery, as the only class you control is the class of the submit element.
If, for instance, you've got several actions rendered as button_to, the only way to properly hook the submits would be to use 'form:has(.some-action-class)' selectors, which is quite convoluted.
This patch adds the :form_class modifier to button_to's html_options.