Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more changes related to @bb43784 ' Removing use of subclassed applicati... #10905

Closed
wants to merge 1 commit into from
Closed

more changes related to @bb43784 ' Removing use of subclassed applicati... #10905

wants to merge 1 commit into from

Conversation

rajars2576
Copy link

...on constant and instead using the'

@rajars2576
Copy link
Author

Hi @arunagw ,

can you please look into this and merge it please?

Thanks

@arunagw
Copy link
Member

arunagw commented Jun 21, 2013

Please rebase this branch with master

@rajars2576
Copy link
Author

Hi Arun,

Thank you for reply.
Actually I removed the branch so should I again create a branch incorporated these changes?
Please help me
Thanks

@arunagw
Copy link
Member

arunagw commented Jun 21, 2013

I think you can create a new branch with same name using this SHA "b0a8ea38ae4a87e60804f1cdabe93a33f1f6a9ee"

But if that feel so complicated close this and open a new pull request.

thanks.

@steveklabnik
Copy link
Member

All you need to do is to push to your my_new_branch branch on GitHub, and it'll be fine. you may have deleted your local branch, but it's still up on your GitHub.

@arunagw
Copy link
Member

arunagw commented Jun 22, 2013

And now you need a rebase with master.

@arunagw
Copy link
Member

arunagw commented Jun 24, 2013

I saw most of these changes are already in master.

Closing this now. Please open a new PR if there are still left.

thanks.

@arunagw arunagw closed this Jun 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants