collection_singular_ids ignores association :include option #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original Lighthouse ticket is https://rails.lighthouseapp.com/projects/8994/tickets/6569-collection_singular_ids-ignores-association-include-option |
|
Can you squash both commits into one?, thanks |
…th conditions and includes, when condtions references tables from includes. Test fail because of invalid sql: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: comments.id: SELECT "posts".id FROM "posts" INNER JOIN "readers" ON "posts"."id" = "readers"."post_id" WHERE "readers"."person_id" = 1 AND (comments.id is null) Bug described in github#925 This commit will revert fix from 3436fdf , but tests is ok. Bug described in #6569 ticket.
|
Gist is good enough https://gist.github.com/1068249 or should I create another pull request? Thanks |
|
you can just push -f to your collection_singular_ids branch and github will do the right thing |
|
thanks, github is really smart |
spastorino
added a commit
that referenced
this pull request
Jul 7, 2011
collection_singular_ids ignores association :include option
|
@lysenko should this be backported to 3-1-stable? |
|
@spastorino it should not, I think this patch can wait for next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was already on lighthouse. No one pay attention, so I make this pull request.
Github issue #925