3-2-stable patch: Add respond_to_missing? in TaggedLoggging #11486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log abstracter wraps a TaggedLogging instance. It's also best practice when overriding method_missing.
|
Could you put the changelog entry on the top? |
rafaelfranca
added a commit
that referenced
this pull request
Jul 18, 2013
…o_missing_in_tagged_loggging 3-2-stable patch: Add respond_to_missing? in TaggedLoggging
wolframarnold
pushed a commit
to wolframarnold/rails
that referenced
this pull request
Jul 19, 2013
Moved order of contibution in Changelog per Rafael's request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added respond_to_missing? for TaggedLogging which is needed if another log abstracter wraps a TaggedLogging instance.
Implementing respond_to_missing? is also a Ruby best practice when overriding method_missing.