Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle polymorphic_type NOT NULL columns #1187

Merged
merged 1 commit into from
May 21, 2011
Merged

Handle polymorphic_type NOT NULL columns #1187

merged 1 commit into from
May 21, 2011

Conversation

thedarkone
Copy link
Contributor

ActiveRecord::Associations::BelongsToPolymorphicAssociation#klass returns a wrong value if the polymorphic_type attribute contains an empty string (''.constantize returns an Object instead of nil).

spastorino added a commit that referenced this pull request May 21, 2011
@spastorino
Merge pull request #1187 from thedarkone/polymorphic-class-fix
da8469f 
Handle polymorphic_type NOT NULL columns
@spastorino spastorino merged commit da8469f into rails:master May 21, 2011
jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011
@josh
Validate template extensions [rails#1187 state:resolved]
2fc6c7d
@thedarkone thedarkone mentioned this pull request Mar 30, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thedarkone @spastorino