Fix todo Time.xmlschema used instead of Time.parse #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder why we have this todo in the first place. Maybe xmlschema was not available in previous rails versions? and I am almost sure we need to require "time" in order to use it. |
|
@josevalim yeah. commits updated |
josevalim
added a commit
that referenced
this pull request
May 22, 2011
Fix todo Time.xmlschema used instead of Time.parse
|
@josevalim do you have any idea how to fix #TODO use regexp instead of Date.parse |
|
No idea. |
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
…n ActionPack Signed-Off-By: Michael Koziarski <michael@koziarski.com> [rails#1202 state:committed]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix todo Time.xmlschema used instead of Time.parse