Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also reset put_via_redirect and delete_via_redirect. #1236

Closed
wants to merge 1 commit into from
Closed

Also reset put_via_redirect and delete_via_redirect. #1236

wants to merge 1 commit into from

Conversation

ntalbott
Copy link
Contributor

We ran in to an issue upgrading a Rails 2.3.10 project to Rails 3.0 due to put_via_redirect not being included in the list of methods that Runner wraps with a reset for @html_document. I also added delete_via_redirect for completeness.

@josevalim
Copy link
Contributor

Tests please?

@ntalbott
Copy link
Contributor Author

I wasn't able to find tests for this code; it may fall under the category of "tests for tests" since this is part of the integration testing infrastructure. If I've missed the tests please point me in the right direction and I'll be happy to add tests to make sure these methods are covered.

@sikachu
Copy link
Member

sikachu commented Jul 11, 2011

You might try to add some test in actionpack/test/dispatch/integration_test.rb. Just create it and add your failing test case, so we know what you're fixing. ;)

@carlosantoniodasilva
Copy link
Member

@ntalbott Do you think you can bring this up-to-date with current master and add some tests, so we could merge? Thanks.

@ntalbott
Copy link
Contributor Author

Don't have the cycles, unfortunately. Anyone else should feel free to pick it up, though. I'll close for now.

@ntalbott ntalbott closed this Mar 29, 2012
@carlosantoniodasilva
Copy link
Member

@ntalbott alright, thanks for reporting back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants