Fix offset with last. #13149
Merged
Fix offset with last. #13149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #7441
carlosantoniodasilva
added a commit
that referenced
this pull request
Dec 3, 2013
Fix offset with last.
|
@carlosantoniodasilva don't forgot to backport, if needed |
|
👍 |
|
Thanks! |
carlosantoniodasilva
added a commit
that referenced
this pull request
Dec 3, 2013
Fix offset with last. Edit: improve changelog.
|
I closed #9606 because it was targeting the wrong branch. For the next time we should at least give the original author a couple days to make the changes requested instead of resubmitting his work. |
|
@senny I'm sorry about that 😔 |
carlosantoniodasilva
added a commit
that referenced
this pull request
Dec 5, 2013
This reverts commit e18b2ca. Reason: this change in behavior may cause some unexpected breakage in applications relying on a stable version/branch, so we are leaving it only on Rails master for now (which will be available with the 4.1 release). Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/finder_test.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version for #9606
Closes #7441
\cc @senny