Remove line causing uninitialized constant Sprockets::Helpers #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell this is not needed. Running the task with the original line, ActionView::Helpers::SprocketsHelper, does nothing different to the final output. Whatever the case, I could find nowhere that Sprockets::Helpers is defined. Other option is to revert 9701014
|
Looks like this is happening because of an inconsistant state between master and 3-1-stable. Particularly actionpack/lib/sprockets/helpers which doesn't exist in 3-1-stable. Still questionable if it is actually needed. |
|
This is actually only happening in rails 3-1-stable... |
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
…aram Signed-off-by: Michael Koziarski <michael@koziarski.com> [rails#1341 state:committed]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell this is not needed. Running the task with the original
line, ActionView::Helpers::SprocketsHelper, does nothing different to the final output.
Whatever the case, I could find nowhere that Sprockets::Helpers is defined.
Other option is to revert 9701014
@josh can you shed some light on this?