Prevent foreign_key_for? from evaluating all attributes #14140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -232,7 +232,7 @@ def invertible_for?(record) | |||
|
|
|||
| # Returns true if record contains the foreign_key | |||
| def foreign_key_for?(record) | |||
| record.attributes.has_key? reflection.foreign_key | |||
| record.attribute_names.include? reflection.foreign_key | |||
There was a problem hiding this comment.
Nice catch. You could actually make use of has_attribute? which is public api.
|
@carlosantoniodasilva thanks, changed! |
|
May you add tests for this? |
|
@pftg: there's no feature change, nor bugfix. This is "only" a speed improvement. |
|
@dmathieu thanks |
|
💖 |
carlosantoniodasilva
added a commit
that referenced
this pull request
Feb 21, 2014
Prevent foreign_key_for? from evaluating all attributes
|
Thanks. |
carlosantoniodasilva
added a commit
that referenced
this pull request
Feb 21, 2014
Prevent foreign_key_for? from evaluating all attributes
carlosantoniodasilva
added a commit
that referenced
this pull request
Feb 21, 2014
Prevent foreign_key_for? from evaluating all attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes should be evaluated lazily if possible (this prevents slow type-casting of date/time/timestamp columns when they are not used).
attributes.has_key?caused all attributes to be evaluated just to set inverse association record instance.