This should fix the 7 tests failing on master for ActiveRecord #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These tests are passing with ruby-1.9.2-p180 Can you see this #1417 |
|
Yep, that works for me. |
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
http://www.faqs.org/rfcs/rfc2045.html says: may be represented by an "=" followed by a two digit hexadecimal representation of the octet's value. The digits of the hexadecimal alphabet, for this purpose, are "0123456789ABCDEF". Uppercase letters must be used; lowercase letters are not allowed. ActionMailer, however, used "=%02x" specification. Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the 7 tests failing on master for ActiveRecord
test_loading_the_association_target_should_keep_child_records_marked_for_destruction
The part object was divorced from the association, so the instance variable for mark_for_destruction could never be reached.
test_should_not_overwrite_unsaved_updates_when_loading_association and #test_should_not_remove_scheduled_destroys_when_loading_association
As far as I can tell, nested attributes are not enough to force a load of an association.
TestHasManyAutosaveAssociationWhichItselfHasAutosaveAssociations
Avoid accessing the association directly in setup, in light of the two test cases below it. Both of those cases had been loading the association directly, by mistake.