ActiveRecord::QueryMethods#reorder with nil argument still removes the default_scope order

[jhephs]

I'm using Rails 4.1.0.rc1 and I have the following

class User < ActiveRecord::Base
  default_scope { order(:created_at => :desc) }
end

class UsersController < ApplicationController
  def index
    @users = User.reorder(params[:order])
  end
end

> User.all.to_sql
 => "SELECT `users`.* FROM `users`   ORDER BY `users`.`created_at` DESC"
> User.reorder(nil).to_sql
 => "SELECT `users`.* FROM `users`"

I don't know if this is more of a feature request but I'm guessing that this is somehow common. I expect the reorder method not to remove the default order if the passed argument is nil.

[pftg]

reorder(nil) is common way to clean order, so this is expected behaviour.

[jhephs]

@pftg Can't we use except(:order) or unscope(:order) to clean order instead?

[pftg]

yep, you can use it
FYI, if you will create PR to change this behaviour:

rails/activerecord/lib/active_record/relation/calculations.rb

Line 234 in 929c226

relation = reorder(nil)

P.S. please re-ask this question on ruby on rails core mailing list

[robin850]

#reorder is meant to remove all existing orders:

# Replaces *any* existing order defined on the relation with the specified order.

You can post your feature request to the rails-core mailing list as pointed by @pftg but I'm not sure that this is worth and actually achievable to be honest. Thank you guys!