Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert source to string if it is present. #15312

Merged
merged 1 commit into from
May 25, 2014
Merged

Convert source to string if it is present. #15312

merged 1 commit into from
May 25, 2014

Conversation

JuanitoFatas
Copy link
Contributor

We will save one to_s conversion if the source is not present.

senny added a commit that referenced this pull request May 25, 2014
Convert source to string if it is present.
@senny senny merged commit 21ec7fe into rails:master May 25, 2014
@senny
Copy link
Member

senny commented May 25, 2014

looks good.

@JuanitoFatas JuanitoFatas deleted the action_view/asset_path branch May 25, 2014 19:05
matthewd added a commit that referenced this pull request Sep 13, 2014
…_path"

This reverts commit 21ec7fe.

Per #16911, there's actually a good reason for a "blank" value to have a
useful `to_s` here. So let's also add some tests to prove that.
trungpham pushed a commit to trungpham/rails that referenced this pull request Sep 18, 2014
…asset_path"

This reverts commit 21ec7fe.

Per rails#16911, there's actually a good reason for a "blank" value to have a
useful `to_s` here. So let's also add some tests to prove that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants