Rails 4.2 image_tag no longer accepts Paperclip::Attachment correctly

[afn]

There's a subtle change in asset_path between Rails 4.1 and 4.2 which breaks the ability to pass Paperclip::Attachment objects to image_tag.

It changed from:

source = source.to_s
return "" unless source.present?

to:

return "" unless source.present?
source = source.to_s

Suppose you have a model like:

class User < ActiveRecord::Base
  has_attached_file :avatar, default_url: 'avatar_missing.png'
end

If a user doesn't have an avatar, then user.avatar.present? will be false but user.avatar.to_s returns avatar_missing.png. Therefore, image_tag current_user.avatar used to behave as expected:

<img alt="Avatar missing" src="/images/avatar_missing.png" />

but now it sets the src attribute of the img to "":

<img src="" />

[matthewd]

Fixed in 457c876.

Thanks for catching this!