If our connection is explicitly non-strict, tell MySQL #16065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We default to making the connection strict, but have historically relied on the MySQL default when we want it to be non-strict. On some (recent?) versions of MySQL, new connections default to being strict, so if we've been told 'strict:false', we're obliged to pass that on. This fixes a test failure that we've seen turn up on relatively-new development machines, so we do already have a test covering it.
|
|
matthewd
added a commit
that referenced
this pull request
Jul 5, 2014
If our connection is explicitly non-strict, tell MySQL
matthewd
added a commit
that referenced
this pull request
Jul 5, 2014
If our connection is explicitly non-strict, tell MySQL
matthewd
added a commit
that referenced
this pull request
Jul 5, 2014
If our connection is explicitly non-strict, tell MySQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We default to making the connection strict, but have historically relied on the MySQL default when we want it to be non-strict. On some (recent?) versions of MySQL, new connections default to being strict, so if we've been told 'strict:false', we're obliged to pass that on.
This fixes a test failure that we've seen turn up on relatively-new development machines, so we do already have a test covering it.
Specifically, a bunch of the OpenAcademy students were seeing this, and we just told them to ignore it at the time. 馃槓
... and I was also seeing it, but I rarely run MySQL tests locally. 馃槓 馃槓