Append sql_mode instead of overwriting in strict mode #24167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
force-pushed
the
append_sql_mode_instead_of_overwriting_in_strict_mode
branch
3 times, most recently
from
df9d24b
to
262bd9e
Compare
| sql_mode = "REPLACE(#{sql_mode}, 'STRICT_ALL_TABLES', '')" | ||
| sql_mode = "REPLACE(#{sql_mode}, 'TRADITIONAL', '')" | ||
| end | ||
| variables['sql_mode'] = -> { sql_mode } |
There was a problem hiding this comment.
Treating callable values as unquoted is clever but it's not clear, particularly since we're using rescue to handle the condition.
We could omit this from variables and add to the set statement ourselves, like we do with encoding config.
There was a problem hiding this comment.
For example,
sql_mode = "@@SESSION.sql_mode = #{sql_mode_change}"
…
@connection.query "SET #{encoding} #{sql_mode} #{variable_assignments}"
kamipo
force-pushed
the
append_sql_mode_instead_of_overwriting_in_strict_mode
branch
2 times, most recently
from
ff6252e
to
eb3dcac
Compare
| end | ||
| sql_mode_assignment = "@@SESSION.sql_mode = #{sql_mode}, " if sql_mode |
There was a problem hiding this comment.
Omitted sql_mode from variables and added to the set statement ourselves!
For keep the default SQL mode.
kamipo
force-pushed
the
append_sql_mode_instead_of_overwriting_in_strict_mode
branch
from
eb3dcac
to
5ad6ed9
Compare
| end | ||
| sql_mode_assignment = "@@SESSION.sql_mode = #{sql_mode}, " if sql_mode |
There was a problem hiding this comment.
Omitted sql_mode from variables and added to the set statement ourselves!
jeremy
added a commit
that referenced
this pull request
Mar 23, 2016
…writing_in_strict_mode Append sql_mode instead of overwriting in strict mode
|
Thank you @kamipo! |
kamipo
deleted the
append_sql_mode_instead_of_overwriting_in_strict_mode
branch
ochaochaocha3
added a commit
to cre-ne-jp/log-archiver
that referenced
this pull request
Oct 6, 2018
MySQL 5.7.5以降では、SELECT DISTINCTとORDER BYを組み合わせるとき ORDER BYで指定する列をSELECTにも含めなければならなくなった。 その結果、ログ表示画面で年月の一覧を取得するときにエラーが発生する。 データベースの設定でMySQLのSQLモードをTRADITIONALに設定することで MySQL 5.6以前と同じ挙動になるようにする。 参考文献: 1. https://blog.kamipo.net/entry/2015/12/14/171838 2. rails/rails#24167 3. rails/rails#25924 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For keep the default SQL mode.
This is an alternative of #23448.
r? @jeremy Do you think this is a good?