purge database before loading schema, take 2 #16316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran Sam's tests against this branch and the output is consistent with @rubys could you run your tests against this branch as well? Just to make sure I did not mess up when running them in my environment 😓 @dhh could you test wether this branch solves your reported issues with the original patch? @rafaelfranca could you take a look? |
|
I also get test results when running on this branch that are consistent with master (3 known failures due to ruby-i18n/i18n#275). |
|
|
…maintaining-test-schema-for-sql-format"" This reverts commit 5c87b5c.
The rake tasks and the `DatabaseTakss` adapter classes used to assume a configuration at some places. This forced the rake tasks to establish a specific connection before calling into `load_schema`. After #15394 this started to cause issues because it could `purge` the wrong database before loading the schema.
senny
added a commit
that referenced
this pull request
Aug 6, 2014
purge database before loading schema, take 2
|
Here's a workaround for rails 4.1 (+postgres) users who want to use # Put in spec_helper, before call to ActiveRecord::Migration.maintain_test_schema!
if ActiveRecord::Migrator.needs_migration?
puts('Needs migrations, purging test database ..')
ActiveRecord::Tasks::PostgreSQLDatabaseTasks
.new(ActiveRecord::Base.configurations.fetch('test'))
.purge
end |
senny
added a commit
that referenced
this pull request
Aug 27, 2014
purge database before loading schema, take 2 Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/tasks/database_tasks.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the behavior introduced by #15394 which was reverted with 5c87b5c
The original patch introduced regressions where the wrong database was purged before loading the schema. The rake tasks no longer open specific connections but tell
DatabaseTaskson whatconfigurationto act on.I had to create a temporary method
load_schema_forbecauseDatabaseTasksis public API andload_schemaneeds a new first argument. After the deprecation cycle we can renameload_schema_forback toload_schema.This functionality is required to for the foreign key support of
schema.rb.I can squash the commits if necessary but wanted to have the diff to the patch explicit for the review.