Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] updated 'where' in association documention to new style syntax #16501

Merged
merged 1 commit into from
Aug 14, 2014
Merged

[ci skip] updated 'where' in association documention to new style syntax #16501

merged 1 commit into from
Aug 14, 2014

Conversation

tomkadwill
Copy link
Contributor

No description provided.

@@ -1209,7 +1209,7 @@ module ClassMethods
# Option examples:
# has_many :comments, -> { order "posted_on" }
# has_many :comments, -> { includes :author }
# has_many :people, -> { where("deleted = 0").order("name") }, class_name: "Person"
# has_many :people, -> { where(deleted: false).order(:name) }, class_name: "Person"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on using deleted: false but order is receiving a string in the rest of the examples ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spastorino Fixed in fdd4b73

zzak pushed a commit that referenced this pull request Aug 14, 2014
[ci skip] updated 'where' in association documention to new style syntax
@zzak zzak merged commit b131978 into rails:master Aug 14, 2014
zzak pushed a commit to zzak/rails that referenced this pull request Aug 14, 2014
@tomkadwill tomkadwill deleted the update_delete_to_new_style branch August 26, 2014 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants