Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use less iterations for KeyGenerator in tests #16717

Merged
merged 1 commit into from Aug 27, 2014
Merged

Use less iterations for KeyGenerator in tests #16717

merged 1 commit into from Aug 27, 2014

Conversation

splattael
Copy link
Contributor

This commit improves performance of cookie tests:

Ruby After Before
MRI 5.03s 9.28s
JRuby 25.45s 1648.23s

Please note the improvement for JRuby.

Let's wait for Travis to finish...

Use less iterations for KeyGenerator in tests
03e660e 
This commit improves performance of cookie tests:

Ruby  |   After  |   Before
----- | --------:| --------:
MRI   |    5.03s |     9.28s
JRuby |   25.45s |  1648.23s

Please note the improvement for JRuby.
@splattael
Copy link
Contributor Author

Travis has finished.

rake test for GEM=ap is much faster now especially on JRuby: 2560.88s -> 36.54s

BTW, in some tests we already reduce iterations to make tests faster:

rails/activesupport/test/key_generator_test.rb

Line 16 in b9b5213

@generator = ActiveSupport::KeyGenerator.new(@secret, :iterations=>2)

spastorino added a commit that referenced this pull request Aug 27, 2014
@spastorino
Merge pull request #16717 from splattael/keygenerator
f1a5e15 
Use less iterations for KeyGenerator in tests
@spastorino spastorino merged commit f1a5e15 into rails:master Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@splattael @spastorino