Warning about middleware not auto-reloading

[Bounga]

Add a section in the guide to explain that Rails can't auto-reload
a middleware on code change.

Fix #16806

[seuros]

This sentence is strange. What about 'Middlewares are loaded once and are not monitored for changes.'

[Bounga]

Yes you're right. I'm going to change this.

[thedarkone]

👍

However thinking about it, for development, you could use something like this:

class MiddlewareTester
  def initialize(app, tested_middleware_const_name, require_path = nil)
    @app = app
    @tested_middleware_const_name = tested_middleware_const_name
    @require_path = require_path
  end

  def call(env)
    load(@require_path) if @require_path # might be brittle
    tested_middleware_const_name.constantize.new(@app).call(env)
  end
end

[seuros]

Now we are repeating ourself, we just said that they are not monitored.

[Bounga]

I think we must say explicitly that the server has to be restarted for the changes to be effective. So what to do? Combine both sentences?

[seuros]

I'm talking about

are not monitored for changes.

and

Middleware changes will not be automatically picked up

[Bounga]

Why does Travis build failed on a guide update?

[Bounga]

So it is not good enough to be included in the guide?

[seuros]

Travis sometime timeout, please add [ci skip] in your commit message when sending doc.
Please squash your commit now. Look good to merge.

[rafaelfranca]

Is not this paragraph redundant?

[Bounga]

Maybe yes, I wanted to emphasis on the fact that as a Rails developer of a middleware you have this strong constraint.

[seuros]

I think we can remove that.

[seuros]

@Bounga Please rebase/squash commits..

[Bounga]

@seuros Sorry about the rebase/squash lag. I was new to that so I had to dig about the good way to do it.

The guide (http://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#contributing-to-the-rails-code) is missing a little tip about the command git rebase -i which is how to select the number of commits to rebase: git rebase -i HEAD~4 for example.

[seuros]

Thank you.