Added 'tzinfo-data' if we are using jruby #17423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spastorino
added a commit
that referenced
this pull request
Oct 29, 2014
Added 'tzinfo-data' if we are using jruby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I develop Rails on Windows, yepp...shame on me. With JRuby I find myself to add 'tzinfo-data' gem everytime I start a new project.
RUBY_PLATFORMwith JRuby is always 'java', so we have to match this case, but It's a little bittricky to find out if we are using JRuby on Windows.
I don't want to add and if-else clause for just one case, It's a problem to add it everytime we have Platform == 'java'? Can we add it to default if platform is jruby?
Otherwise we can check if: