Update docs 6 #17526
Merged
Update docs 6 #17526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishijain
commented
Nov 6, 2014
rishijain
commented
- Added example of squish!
- Added example of remove
- Added example of remove!
- Added test case for removal of multiple occurrences of pattern.
| @@ -273,7 +279,7 @@ def test_remove! | |||
| assert_equal "This is a good day", original.remove!(" to ", /die/) | |||
| assert_equal "This is a good day", original | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
I don't know why that came in the diff. As you can see I have just one line break above test_constantize.
There was a problem hiding this comment.
It's not a line break it's whitespace. Looks like you have an extra added space or 2 😸
I add this to my .vimrc to highlight whitespace in bright red. Hope that helps!
" Hightlight whitespace and tabs
highlight ExtraWhitespace ctermbg=red guibg=red
match ExtraWhitespace /\s\+$/
autocmd BufWinEnter * match ExtraWhitespace /\s\+$/
autocmd InsertEnter * match ExtraWhitespace /\s\+\%#\@<!$/
autocmd InsertLeave * match ExtraWhitespace /\s\+$/
There was a problem hiding this comment.
And yes indeed. There were whitespaces. Thanks @eileencodes
|
Can you please squash all the commits to one? |
|
Added a new PR (#17532) with squashed commits. |
|
Just force push in this branch, i closed the other. Without the ci_skip since there is a new test. |
rishijain
force-pushed
the
update_docs_6
branch
from
7730184
to
3f58df3
Compare
|
Done. |
|
Please remove the [ci_skip] from the commit message. |
pattern removal added example for string#remove and test case for remove of multiple occurence of pattern removed extra whitespaces
rishijain
force-pushed
the
update_docs_6
branch
from
3f58df3
to
54a9653
Compare
|
Done. Thankyou @seuros for the patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.