Correctly dump :options on create_table for MySQL
#17569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'cp932' => 'cp932_japanese_ci', | ||
| 'eucjpms' => 'ucjpms_japanese_ci' | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure these are necessary. If collation is omitted, MySQL will use its default for that charset.
|
👍 to the idea. It's important to support Barracuda formats. |
kamipo
force-pushed
the
dump_table_options
branch
from
bf876a8
to
f44759e
Compare
kamipo
force-pushed
the
dump_table_options
branch
2 times, most recently
from
9a69d48
to
7f1606d
Compare
kamipo
force-pushed
the
dump_table_options
branch
from
7f1606d
to
c0f168f
Compare
|
@matthewd any concern about this one? It will update all the schema tables to explicitly set the |
|
👍; avoiding a bulk schema change does seem slightly desirable, but not important. And explicitness has its own value here, too. |
kamipo
force-pushed
the
dump_table_options
branch
from
c0f168f
to
454578b
Compare
|
👍 I have currently to monkey patch activerecord to correctly create table from the schema and with the rights options (We're verifying that we able to store utf8bm4 character like 𝌆 for example. |
kamipo
force-pushed
the
dump_table_options
branch
from
454578b
to
964ff7e
Compare
kamipo
changed the title
:options on create_table for MySQL
|
@rafaelfranca Could you merge the changes? |
rafaelfranca
added a commit
that referenced
this pull request
May 3, 2015
Correctly dump `:options` on `create_table` for MySQL
|
👍 |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Aug 25, 2017
I was added a table options after `force: :cascade` in rails#17569 for not touching existing tests (reducing diff). But `force: :cascade` is not an important information. So I prefer to place a table options before `force: :cascade`.
tgxworld
pushed a commit
to tgxworld/rails
that referenced
this pull request
Aug 27, 2017
I was added a table options after `force: :cascade` in rails#17569 for not touching existing tests (reducing diff). But `force: :cascade` is not an important information. So I prefer to place a table options before `force: :cascade`.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
May 23, 2020
…e agnostic 5 years ago, I made dumping full table options at rails#17569, especially to dump `ENGINE=InnoDB ROW_FORMAT=DYNAMIC` to use utf8mb4 with large key prefix. In that time, omitting the default engine `ENGINE=InnoDB` was not useful since `ROW_FORMAT=DYNAMIC` always remains as long as using utf8mb4 with large key prefix. But now, MySQL 5.7.9 has finally changed the default row format to DYNAMIC, utf8mb4 with large key prefix can be used without dumping the default engine and the row format explicitly. So now is a good time to make the default engine is omitted. Before: ```ruby create_table "accounts", options: "ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci", force: :cascade do |t| end ``` After: ```ruby create_table "accounts", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t| end ``` To entirely omit `:options` option to make schema agnostic, I've added `:charset` and `:collation` table options to exclude `CHARSET` and `COLLATE` from `:options`. Fixes rails#26209. Closes rails#29472. See also rails#33608, rails#33853, and rails#34742.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #12172.
Is often used to specify table_options in MySQL.
(For example,
"ENGINE=MyISAM"for full-text search,"ENGINE=InnoDB ROW_FORMAT=DYNAMIC"or"ENGINE=InnoDB ROW_FORMAT=COMPRESSED KEY_BLOCK_SIZE=8"for use InnoDB of Barracuda File Format.)SchemaDumper should support a dump of table_options.