Nesting adapter specific table options #29472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per #27981 (comment), I don't think we should ignore settings that mean something, and we should instead aim to exclude default settings from the schema dump. r? @jeremy |
kamipo
force-pushed
the
nesting_adapter_specific_table_options
branch
2 times, most recently
from
8062b88
to
79efed0
Compare
kamipo
force-pushed
the
nesting_adapter_specific_table_options
branch
2 times, most recently
from
0333c91
to
b6ab3b8
Compare
kamipo
force-pushed
the
nesting_adapter_specific_table_options
branch
from
b6ab3b8
to
e0e90a9
Compare
kamipo
force-pushed
the
nesting_adapter_specific_table_options
branch
from
e0e90a9
to
acbbd81
Compare
kamipo
force-pushed
the
nesting_adapter_specific_table_options
branch
2 times, most recently
from
daf869b
to
2c0d274
Compare
kamipo
force-pushed
the
nesting_adapter_specific_table_options
branch
from
2c0d274
to
23b1891
Compare
|
When does this going to merged? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
To ignore invalid table options for other adapters. Fixes rails#26209.
kamipo
force-pushed
the
nesting_adapter_specific_table_options
branch
from
23b1891
to
4dc6de9
Compare
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
May 23, 2020
…e agnostic 5 years ago, I made dumping full table options at rails#17569, especially to dump `ENGINE=InnoDB ROW_FORMAT=DYNAMIC` to use utf8mb4 with large key prefix. In that time, omitting the default engine `ENGINE=InnoDB` was not useful since `ROW_FORMAT=DYNAMIC` always remains as long as using utf8mb4 with large key prefix. But now, MySQL 5.7.9 has finally changed the default row format to DYNAMIC, utf8mb4 with large key prefix can be used without dumping the default engine and the row format explicitly. So now is a good time to make the default engine is omitted. Before: ```ruby create_table "accounts", options: "ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci", force: :cascade do |t| end ``` After: ```ruby create_table "accounts", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t| end ``` To entirely omit `:options` option to make schema agnostic, I've added `:charset` and `:collation` table options to exclude `CHARSET` and `COLLATE` from `:options`. Fixes rails#26209. Closes rails#29472. See also rails#33608, rails#33853, and rails#34742.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ignore invalid table options for other adapter.
Fixes #26209.