Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always default the log_level to :info for Railties #17757

Merged
merged 1 commit into from
Nov 25, 2014

Conversation

zzak
Copy link
Member

@zzak zzak commented Nov 25, 2014

See also #16622 and a6de6f5

Changelog: #17755
Test: #17756

cc @chancancode @matthewd

@@ -143,6 +143,7 @@ def build_app(options = {})
config.active_support.deprecation = :log
config.active_support.test_order = :random
config.action_controller.allow_forgery_protection = false
config.log_level = :debug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be :info? I'm almost sure it will speed up the tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and updated ticket name

@zzak zzak force-pushed the railties-default-to-debug-log_level branch from 2373174 to 116de07 Compare November 25, 2014 03:08
@zzak zzak changed the title Always default the log_level to :debug for Railties Always default the log_level to :info for Railties Nov 25, 2014
@chancancode chancancode self-assigned this Nov 25, 2014
@chancancode chancancode modified the milestone: 4.2.0 Nov 25, 2014
chancancode added a commit that referenced this pull request Nov 25, 2014
Always default the log_level to :info for Railties
@chancancode chancancode merged commit 6b8cd68 into rails:master Nov 25, 2014
@zzak zzak deleted the railties-default-to-debug-log_level branch November 25, 2014 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants