Don't fight against ourselves for the default log level #16622

Merged
merged 1 commit into from Aug 22, 2014

Conversation

Projects
None yet
7 participants
@matthewd
Member

matthewd commented Aug 21, 2014

If we want to always default to :debug, let's just do that.

At which point the production.rb entry can become an "uncomment to change" instead.

Don't fight against ourselves for the default log level
If we want to always default to :debug, let's just do that.

At which point the production.rb entry can become an "uncomment to
change" instead.
@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
Member

rafaelfranca commented Aug 21, 2014

:shipit:

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
Member

rafaelfranca commented Aug 21, 2014

:shipit:

@spastorino

This comment has been minimized.

Show comment
Hide comment
Member

spastorino commented Aug 22, 2014

:shipit:

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Aug 22, 2014

Member

🚢 🇮🇹

Member

zzak commented Aug 22, 2014

🚢 🇮🇹

matthewd added a commit that referenced this pull request Aug 22, 2014

Merge pull request #16622 from matthewd/default-debug
Don't fight against ourselves for the default log level

@matthewd matthewd merged commit 2602a49 into rails:master Aug 22, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
@@ -117,7 +117,7 @@ def database_configuration
end
def log_level
- @log_level ||= Rails.env.production? ? :info : :debug
+ @log_level ||= :debug

This comment has been minimized.

@chancancode

chancancode Aug 30, 2014

Member

@matthewd This would change the default for existing applications too, whereas the older implementation would keep the same default for existing applications, c/d? While this is probably okay, we should at least mention it in the upgrade guides.

@chancancode

chancancode Aug 30, 2014

Member

@matthewd This would change the default for existing applications too, whereas the older implementation would keep the same default for existing applications, c/d? While this is probably okay, we should at least mention it in the upgrade guides.

This comment has been minimized.

@SamSaffron

SamSaffron Nov 17, 2014

Contributor

+1 on this being a high risk change, people are going to be bitten by this hard. (eg: why is my app so slow, ahhh ... you have log level set to debug)

@SamSaffron

SamSaffron Nov 17, 2014

Contributor

+1 on this being a high risk change, people are going to be bitten by this hard. (eg: why is my app so slow, ahhh ... you have log level set to debug)

This comment has been minimized.

@sergey-alekseev

sergey-alekseev Dec 27, 2014

Contributor

Actually I found this change complicating the debugging process because of too many logs. So changed back to config.log_level = :info.

@sergey-alekseev

sergey-alekseev Dec 27, 2014

Contributor

Actually I found this change complicating the debugging process because of too many logs. So changed back to config.log_level = :info.

chancancode added a commit that referenced this pull request Nov 17, 2014

Revert "Merge pull request #16622 from matthewd/default-debug"
This reverts commit 2602a49, reversing
changes made to 5d7c105.

The explicit default was introduced in 21f6d72, so apps created with Rails < 4
have the commented out version, which means that this change would break those
apps.

swanandp added a commit to Simplero/rails that referenced this pull request Nov 18, 2014

Revert "Merge pull request #16622 from matthewd/default-debug"
This reverts commit 2602a49, reversing
changes made to 5d7c105.

The explicit default was introduced in 21f6d72, so apps created with Rails < 4
have the commented out version, which means that this change would break those
apps.

zzak added a commit to zzak/rails that referenced this pull request Nov 25, 2014

zzak added a commit to zzak/rails that referenced this pull request Nov 25, 2014

zzak added a commit to zzak/rails that referenced this pull request Nov 25, 2014

chancancode added a commit that referenced this pull request Nov 25, 2014

Merge pull request #17755 from zzak/changelog-for-16622
Add a CHANGELOG entry for #16622 and a6de6f5 [ci skip]

sachin004 added a commit to sachin004/rails that referenced this pull request Dec 13, 2014

Revert "Merge pull request #16622 from matthewd/default-debug"
This reverts commit 2602a49, reversing
changes made to 5d7c105.

The explicit default was introduced in 21f6d72, so apps created with Rails < 4
have the commented out version, which means that this change would break those
apps.

sachin004 added a commit to sachin004/rails that referenced this pull request Dec 13, 2014

@matthewd matthewd deleted the matthewd:default-debug branch Aug 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment