Fix handling of positional url helper arguments when format is false #18020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to subtract one from the path_params size when there is no format parameter because it is not present in the path_params array. Fixes rails#17819.
pixeltrix
added a commit
that referenced
this pull request
Dec 13, 2014
…h-format-false Fix handling of positional url helper arguments when format is false
|
@rafaelfranca @chancancode should this be backported to just 4-2-stable and left out of the 4.2.0 release - otherwise it means another RC release - it's a fairly old bug. Also what about backporting to 4-1-stable and 4-0-stable? |
|
👍 on leaving it out of 4-2-0 branch. 4-1-stable I'm not sure, but I think it's fine to backport 😄 |
|
@pixeltrix 👍 for backporting to 4-0 and 4-1-stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to subtract one from the path_params size when there is
no format parameter because it is not present in the path_params array.
Fixes #17819.