Bugfix collection association #create method #18155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Almost this exact change was introduced a few months back, but was reverted because it introduced another bug. I'll see if I can find it. |
|
@sgrif did you ever find that other big? |
|
@sgrif do you have some time to look into it again? |
|
It looks like this PR conflicts with master branch :) |
|
I'll look into it |
When same association is loaded in the model creation callback The new object is inserted into association twice
bogdan
force-pushed
the
collection_association_double_element_fix
branch
from
982f341
to
6d0d83a
Compare
|
rebased |
|
Welp, can't find what I was thinking of. If I actually did revert a change for causing problems, I expect that I would have added a test case. So ¯_(ツ)_/¯ |
sgrif
added a commit
that referenced
this pull request
Nov 29, 2015
…lement_fix Bugfix collection association #create method
This was referenced Feb 16, 2016
vipulnsward
added a commit
to vipulnsward/rails
that referenced
this pull request
Feb 16, 2016
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Apr 20, 2017
… parent association saved in the callback Related rails#18155, rails#26661, 268a5bb, rails#27434, rails#27442, and rails#28599. Originally rails#18155 was introduced for preventing double insertion caused by the after save callback. But it was caused the before save issue (rails#26661). 268a5bb fixed rails#26661, but it was caused the performance regression (rails#27434). rails#27442 added new record to `target` before calling callbacks for fixing rails#27434. But it was caused double firing before save callback (rails#28599). We cannot add new object to `target` before saving the object. This is improving rails#18155 to only track callbacks after `save`. Fixes rails#28599.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When same association is loaded in the model creation callback
The new object is inserted into association twice.