private/protected indentation fixes according to rails coding conventions #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, but those style changes just break the other pull requests without an explicit gain. |
|
Should I make those changes in small chunks? I ran the testcases and everything was fine. |
|
Thanks but there is no need. We are in general denying style changes. |
|
Got it. Thanks |
|
Also this style changes are wrong. private, protected and public are just method calls so code shouldn't be indented after them. |
|
but the guide lines are asking us to do so.. and I can see them in many rails libs too... |
|
Yeah ok, the guides are wrong so :), we need to fix that |
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
…te:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
I actually think private/protected should be outdented. |
brigade-gerrit
pushed a commit
to causes/rails
that referenced
this pull request
Nov 15, 2013
Fix incorrect recommendation from indenting after private/protected to not. Based on opinions of @spastorino, @jonleighton, @tenderlove rails#1838 (comment) https://en.twitter.com/#!/spastorino/status/142054749351575552 https://en.twitter.com/#!/tenderlove/status/142014046445641728 https://en.twitter.com/#!/jonleighton/status/142021813415841794
rtyley
pushed a commit
to bfg-repo-cleaner-demos/rails-with-all-non-head-files-deleted
that referenced
this pull request
Sep 11, 2023
Fix incorrect recommendation from indenting after private/protected to not. Based on opinions of @spastorino, @jonleighton, @tenderlove rails/rails#1838 (comment) https://en.twitter.com/#!/spastorino/status/142054749351575552 https://en.twitter.com/#!/tenderlove/status/142014046445641728 https://en.twitter.com/#!/jonleighton/status/142021813415841794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few private/protected indentation fixes in ActiveRecord, according to rails coding conventions given here http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions