Use option url: false to allow entries without a link tag #18437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @xml.link(:rel => 'alternate', :type => type, :href => options[:url] || @view.polymorphic_url(record)) | ||
| unless options[:url] == false | ||
| @xml.link(:rel => 'alternate', :type => type, :href => options[:url] || @view.polymorphic_url(record)) | ||
| end |
There was a problem hiding this comment.
I'd do something like this ...
url = options.fetch(:url) { @view.polymorphic_url(record) }
@xml.link(:rel => 'alternate', :type => type, :href => url) if urlBecause you want @view.polymorphic_url(record) to be executed if options[:url] isn't set. But if somebody does set it, regardless if it's nil or false you want to skip that.
|
Other than that looks good 👍 |
eldano
force-pushed
the
feed_entry_no_link_option
branch
from
f1cac4d
to
b39bb9b
Compare
|
@spastorino I agree with your comment, it's changed now |
| @@ -174,7 +174,7 @@ def updated(date_or_time = nil) | |||
| # | |||
| # * <tt>:published</tt>: Time first published. Defaults to the created_at attribute on the record if one such exists. | |||
| # * <tt>:updated</tt>: Time of update. Defaults to the updated_at attribute on the record if one such exists. | |||
| # * <tt>:url</tt>: The URL for this entry. Defaults to the polymorphic_url for the record. | |||
| # * <tt>:url</tt>: The URL for this entry or false for not having a link tag. Defaults to the polymorphic_url for the record. | |||
There was a problem hiding this comment.
@eldano it should say that url: nil will omit the tag as well.
There was a problem hiding this comment.
@sdebarros Thanks for spotting this!
eldano
force-pushed
the
feed_entry_no_link_option
branch
from
b39bb9b
to
6ba4c6d
Compare
spastorino
added a commit
that referenced
this pull request
Jan 16, 2015
Use option url: false to allow entries without a link tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to omit the link tag.
According to https://tools.ietf.org/html/rfc4287#section-4.1.2