Add Method#source_code

[dhh]

Common pattern for me is to inspect the source code of a method I'm curious about like so:

irb(main):018:0> Recording.find(904).children.method(:load).source_location
  Recording Load (0.3ms)  SELECT  `recordings`.* FROM `recordings` WHERE `recordings`.`id` = 904 LIMIT 1
=> ["/Users/david/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/rails-03e672a3daec/activerecord/lib/active_record/relation.rb", 513]

Then copy the path to the clipboard, then go to the console and do mate path, then APPLE-G to jump to the line.

Let's make that simpler:

irb(main):018:0> puts Recording.find(904).children.method(:load).source_code
  Recording Load (0.3ms)  SELECT  `recordings`.* FROM `recordings` WHERE `recordings`.`id` = 904 LIMIT 1

    # Causes the records to be loaded from the database if they have not
    # been loaded already. You can use this if for some reason you need
    # to explicitly load some records before actually using them. The
    # return value is the relation itself, not the records.
    #
    #   Post.where(published: true).load # => #<ActiveRecord::Relation>
    def load
      exec_queries unless loaded?

      self
    end

[guilleiguaran]

I'll check this!!

[sgrif]

Doesn't pry already provide this?

[dhh]

Link?

On Jan 12, 2015, at 4:58 PM, Sean Griffin notifications@github.com wrote:

Doesn't pry already provide this?

—
Reply to this email directly or view it on GitHub #18473 (comment).

[sgrif]

https://github.com/pry/pry/wiki/Source-browsing#Show_method

[dhh]

Not quite the same thing. Doesn’t seem to work off dynamic methods, like the one I used in the example.

On Jan 12, 2015, at 5:01 PM, Sean Griffin notifications@github.com wrote:

https://github.com/pry/pry/wiki/Source-browsing#Show_method https://github.com/pry/pry/wiki/Source-browsing#Show_method
—
Reply to this email directly or view it on GitHub #18473 (comment).

[sgrif]

Works just fine for me?

[5] pry(main)> show-source User.first.purchases.load
  User Load (0.4ms)  SELECT  "users".* FROM "users"   ORDER BY "users"."id" ASC LIMIT 1

From: /Users/sean/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/activerecord-4.1.5/lib/active_record/relation.rb @ line 485:
Owner: ActiveRecord::Relation
Visibility: public
Number of lines: 5

def load
  exec_queries unless loaded?

  self
end

[dhh]

Ah, it wasn’t listed as one of the examples. In any case, taking on all of pry because you want this seems like shooting pigeons with canons. Pry is an omnibus of stuff.

On Jan 12, 2015, at 5:10 PM, Sean Griffin notifications@github.com wrote:

Works just fine for me?

[5] pry(main)> show-source User.first.purchases.load
User Load (0.4ms) SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1
User Load (0.4ms) SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1
User Load (0.3ms) SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1
User Load (0.3ms) SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1
User Load (0.3ms) SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1

From: /Users/sean/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/activerecord-4.1.5/lib/active_record/relation.rb @ line 485:
Owner: ActiveRecord::Relation
Visibility: public
Number of lines: 5

def load
exec_queries unless loaded?

self
end
—
Reply to this email directly or view it on GitHub #18473 (comment).

[sgrif]

It's by far the most popular debugger. Why include hefty debug methods in every rails app, when a very ubiquitous gem which focuses solely on debugging does the same thing? This feels like Not Invented Here Syndrome to me.

[dhh]

It’s great that there’s a omnibus gem that adds a ton of shit for people who want that. Rails is full of small slices of functionality that’s also included in gems with the kitchen sink included. I see no conflict with that.

On Jan 12, 2015, at 5:15 PM, Sean Griffin notifications@github.com wrote:

It's by far the most popular debugger. Why include hefty debug methods in every rails app, when a very ubiquitous gem which focuses solely on debugging does the same thing? This feels like Not Invented Here Syndrome to me.

—
Reply to this email directly or view it on GitHub #18473 (comment).

[sgrif]

Just seems like we're needlessly duplicating work, and adding more code that we have to maintain. Maybe it's worth reaching out to the pry guys to see if a common module could be pulled out that just provides this functionality, rather than replicating it wholesale?

[dhh]

Please do! Not interested in taking on a dependency gem, though. But if they want to extract Method#source_code, put it into AS, and then use it from Pry, that’s cool with me 👍.

On Jan 12, 2015, at 5:19 PM, Sean Griffin notifications@github.com wrote:

Just seems like we're needlessly duplicating work, and adding more code that we have to maintain. Maybe it's worth reaching out to the pry guys to see if a common module could be pulled out that just provides this functionality, rather than replicating it wholesale?

—
Reply to this email directly or view it on GitHub #18473 (comment).

[sgrif]

Can we not do this? You know it doesn't make sense for a gem which has nothing to do with Rails to move their functionality into Rails, and add AS as a dependency. I'm just saying we might want to think about the maintenance cost of adding something like this to Rails, especially when it's already provided elsewhere.

I once read a really good book by some project management software guys about how every feature you add has a hidden cost.