Fix STI for fixtures from multi-files #18512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vipulnsward
commented
Jan 14, 2015
vipulnsward
commented
- Add check for not deleting previously created fixtures, to overcome sti fixtures from multiple files
- Added fixtures and fixtures test to verify the same
|
Tests related to random named files are failing due to unique constraints. |
| assert_equal pirates(:blackbeard), dead_parrots(:deadbird).killer | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
You added 2 spaces here, it should only be one 😄
- Add check for not deleting previously created fixtures, to overcome sti fixtures from multiple files - Added fixtures and fixtures test to verify the same - Fixed wrong fixtures duplicating data insertion in same table
vipulnsward
force-pushed
the
18492-fixtures-with-sti
branch
from
5578b14
to
4ae59eb
Compare
|
Fixed spacing, also fixed random named fixture test, to not conflict data in a single table. |
| unless deleted_tables.include? table | ||
| conn.delete "DELETE FROM #{conn.quote_table_name(table)}", 'Fixture Delete' | ||
| end | ||
| deleted_tables << table |
There was a problem hiding this comment.
Should this line be inside the unless block?
There was a problem hiding this comment.
either of the way works fine
tenderlove
added a commit
that referenced
this pull request
Feb 1, 2015
Fix STI for fixtures from multi-files
arthurnn
pushed a commit
that referenced
this pull request
Feb 15, 2016
Fix STI for fixtures from multi-files
arthurnn
added a commit
that referenced
this pull request
Feb 23, 2016
…h-sti" This reverts commit 6a25fd1. Reverting this as I thought it was a bug fix, but actually it is not. This is more like a feature addition, as you can have STI for fixtures right now if you have one fixture file for that table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.