Rename AS::Callback#merge #18747
Merged
Rename AS::Callback#merge #18747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -373,7 +373,7 @@ def initialize(name, filter, kind, options, chain_config) | |||
| def filter; @key; end | |||
| def raw_filter; @filter; end | |||
|
|
|||
| def merge(chain, new_options) | |||
| def merge_skip_callback(chain, new_options) | |||
There was a problem hiding this comment.
Maybe merge_conditional_options?
…ck. Renamed it to indicate what it actually does.
vipulnsward
force-pushed
the
merge-skip-callback
branch
from
148e716
to
0928c3f
Compare
|
Sounds even better. Updated. |
| @@ -373,7 +373,7 @@ def initialize(name, filter, kind, options, chain_config) | |||
| def filter; @key; end | |||
| def raw_filter; @filter; end | |||
|
|
|||
| def merge(chain, new_options) | |||
| def merge_conditional_options(chain, new_options) | |||
There was a problem hiding this comment.
As we are here, and merge_conditional_options new_options parameter can only have a if or unless option , I wonder if we should change this to keyargs: something like
def merge_conditional_options(chain, if: [], unless: [])
Not strong about tho, just a thought... @rafaelfranca WDYT?
There was a problem hiding this comment.
I see no reason not to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback#merge merges options for a callback skip instead of a callback. Renamed it to indicate what it actually does.