Remove warning from Plugin Generator #18840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -319,10 +319,10 @@ def modules | |||
|
|
|||
| def wrap_in_modules(content) | |||
| content = "#{content}".strip.gsub(/\W$\n/, '') | |||
| modules.reverse.inject(content) do |content, mod| | |||
| modules.reverse.inject(content) do |kontent, mod| | |||
There was a problem hiding this comment.
I think it is better to rename the outside variable to unwrapped_code
There was a problem hiding this comment.
I'll second that. kontent sounds like a typo (even though it mimics the klass convention).
There was a problem hiding this comment.
unwrapped_code sounds better! i'll change it.
This removes the following warning: rails/railties/lib/rails/generators/rails/plugin/plugin_generator.rb:321: warning: shadowing outer local variable - content
yuki24
force-pushed
the
remove-warning-from-plugin-generator
branch
from
09d3f51
to
39af02a
Compare
|
updated commit. Thanks @vipulnsward @rafaelfranca for reviewing! |
senny
added a commit
that referenced
this pull request
Feb 9, 2015
…rator Remove warning from Plugin Generator
|
@yuki24 thank you. |
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the following warning: