Rake restart task no longer loads entire Rails environment when run

[hjoo]

Fixes #18876. Rake restart touches tmp/restart.txt to restart
application on next request. Updated test and documentation accordingly.

[arthurnn]

[eileencodes]

Probably not going to affect it but I'm waiting til CI finishes to merge 😁

[kaspth]

@hjoo your commit message is off as you've already added the rake task. Can you update your commit message to say the task no longer loads the whole Rails environment when run 😄

If you can, a quick explanation of why the task doesn't need the environment would be great too 👍

[hjoo]

Oops, fixed it! Thanks for the feedback. 👍

[kaspth]

Well done 👍

[waynerobinson]

Shouldn't this also be rails restart to go with the style of #18878?

[olivierlacan]

@waynerobinson Considering this comment the idea is to route commands to rake anyway so this command would have to be added to the supported hybrid rails/rake commands.

[waynerobinson]

@olivierlacan no problem, just making sure there is some consistency here (not that I whole-heartedly approve of everything rails).

[emilsoman]

@hjoo the PR title is misguiding - it looks like the rake task was added in a different PR ?

[eileencodes]

@emilsoman it was but the commit has the correct title. I've edited it but I don't think it's a big deal.

[seanarnold]

I agree with @waynerobinson . if we're adding this then add rails restart too. Especially since you start the server with rails server, it makes sense (to me at least) to have a rails restart command.

[rafaelfranca]

@seanarnold it will be added.

[seanarnold]

👍