Fixes reference for schema_format to AR::Base from AS::Base #19176
Conversation
|
This is missing a test case. |
|
Sure, what do you want to test for? it's essentially a typo fix that obviously didn't have a test to begin with |
|
Calling the method with no arguments so the default is invoked. |
imajes
force-pushed
the
master
branch
2 times, most recently
from
d9227d8
to
110dc67
Compare
|
Fair 'nuff. This should be good to go now then. |
|
|
||
| File.expects(:join).with('/tmp', 'schema.rb') | ||
| ActiveRecord::Tasks::DatabaseTasks.schema_file | ||
| end |
There was a problem hiding this comment.
Isn't better to just assert the result of schema_file? Wdyt?
|
Yeah that's reasonable to check for return. All the other tests were checking expectations so I kinda just jumped on that bandwagon. This should now be all good, plus i threw in a couple tests to exercise both format variations, just for good measure. |
Fixes reference for schema_format to AR::Base from AS::Base
|
thank you 💛 |
|
@senny, can we apply this to Rails 4 branches too? I actually noticed it because I was bitten by it this week switching between |
|
@imajes sure, I merged from my phone 😁 |
Fixes reference for schema_format to AR::Base from AS::Base Conflicts: activerecord/lib/active_record/tasks/database_tasks.rb
|
@imajes backported to |
Hey-
this is a simple fix, but i think it should also get backported to the relevant stable branches in the 4.x series. I don't think it is relevant for 3.x.