Skip to content

Commit

Permalink
Merge pull request #19176 from imajes/master
Browse files Browse the repository at this point in the history
Fixes reference for schema_format to AR::Base from AS::Base
  • Loading branch information
senny committed Mar 3, 2015
2 parents 35db2bc + e3a1bd3 commit b0edabf
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
2 changes: 1 addition & 1 deletion activerecord/lib/active_record/tasks/database_tasks.rb
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def load_schema_for(*args)
load_schema(*args)
end

def schema_file(format = ActiveSupport::Base.schema_format)
def schema_file(format = ActiveRecord::Base.schema_format)
case format
when :ruby
File.join(db_dir, "schema.rb")
Expand Down
16 changes: 16 additions & 0 deletions activerecord/test/cases/tasks/database_tasks_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -377,4 +377,20 @@ def test_check_schema_file
ActiveRecord::Tasks::DatabaseTasks.check_schema_file("awesome-file.sql")
end
end

class DatabaseTasksCheckSchemaFileDefaultsTest < ActiveRecord::TestCase
def test_check_schema_file_defaults
ActiveRecord::Tasks::DatabaseTasks.stubs(:db_dir).returns('/tmp')
assert_equal '/tmp/schema.rb', ActiveRecord::Tasks::DatabaseTasks.schema_file
end
end

class DatabaseTasksCheckSchemaFileSpecifiedFormatsTest < ActiveRecord::TestCase
{ruby: 'schema.rb', sql: 'structure.sql'}.each_pair do |fmt, filename|
define_method("test_check_schema_file_for_#{fmt}_format") do
ActiveRecord::Tasks::DatabaseTasks.stubs(:db_dir).returns('/tmp')
assert_equal "/tmp/#{filename}", ActiveRecord::Tasks::DatabaseTasks.schema_file(fmt)
end
end
end
end

0 comments on commit b0edabf

Please sign in to comment.