[Rails4 regression] prevent thin and puma cause error in Non ASCII URL on Windows #19689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please squash your commits? |
|
Which revisions? |
|
The gemfile changes can be grouped in one commit and the last two commits also. |
|
BTW, awesome work ❤️ |
…L on Windows * #19187 * #19533 * macournoyer/thin#268 These are serious Rails 4 regression for Redmine Bitnami Windows users. https://community.bitnami.com/t/problems-with-3-0-1-installation-see-report-inside/30195/ It is not caused on webrick users. Related: * rack/rack#732 (comment) * phusion/passenger#1328
…ck/test/dispatch/static_test.rb * #19187 * #19533 * macournoyer/thin#268
Done. |
rafaelfranca
pushed a commit
that referenced
this pull request
Apr 9, 2015
rafaelfranca
added a commit
that referenced
this pull request
Apr 9, 2015
[Rails4 regression] prevent thin and puma cause error in Non ASCII URL on Windows
|
Merged at bfe6507 |
rafaelfranca
added a commit
that referenced
this pull request
Apr 9, 2015
[Rails4 regression] prevent thin and puma cause error in Non ASCII URL on Windows
|
Backported as 4df216c |
|
@marutosi thank you so much for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are serious Rails 4 regression for Redmine Bitnami Windows users.
https://community.bitnami.com/t/problems-with-3-0-1-installation-see-report-inside/30195/
It is not caused on webrick users.
Related: