Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rails4 regression] prevent thin and puma cause error in Non ASCII URL on Windows #19533

Closed
wants to merge 5 commits into from
Closed

[Rails4 regression] prevent thin and puma cause error in Non ASCII URL on Windows #19533

wants to merge 5 commits into from

Conversation

marutosi
Copy link
Contributor

@marutosi marutosi mentioned this pull request Mar 26, 2015
Closed
@marutosi marutosi changed the title prevent thin and puma cause error in Non ASCII URL on Windows [Rails4 regression] prevent thin and puma cause error in Non ASCII URL on Windows Mar 28, 2015
@marutosi
Copy link
Contributor Author

Why does not Rails team respond to #19187 and #19533 ?
These are serious Rails 4 regression for Redmine Bitnami Windows users.
https://community.bitnami.com/t/problems-with-3-0-1-installation-see-report-inside/30195/

#19187 is caused on any Windows thin and puma users.
It is not caused on webrick users.

Related:

@marutosi marutosi mentioned this pull request Apr 1, 2015
Closed
@marutosi marutosi mentioned this pull request Apr 7, 2015
Closed
@rafaelfranca
Copy link
Member

Could you please squash your commits? Also please open the PR against the master branch.

@marutosi marutosi mentioned this pull request Apr 8, 2015
Closed
rafaelfranca pushed a commit that referenced this pull request Apr 9, 2015
@marutosi @rafaelfranca
Gemfile: temporay pin "bcrypt" version and run "bundle update bcrypt"…
7008dfb 
… on Linux

Related: #19617, #19187, #19533, #19689, #19675.

This is POC (Proof Of Concept) which bundler does not remove mingw lines.
#19617 (comment)
rafaelfranca pushed a commit that referenced this pull request Apr 9, 2015
@marutosi @rafaelfranca
wrap "require 'drb/unix'" by bgin-end at test/abstract_unit.rb
2a73b59 
Related: #19617, #19187, #19533, #19689, #19675.

'drb/unix' does not exist on mingw.
rafaelfranca pushed a commit that referenced this pull request Apr 9, 2015
@marutosi @rafaelfranca
[Rails4 regression] prevent thin and puma cause error in Non ASCII UR…
7e50492 
…L on Windows

* #19187
* #19533
* macournoyer/thin#268

These are serious Rails 4 regression for Redmine Bitnami Windows users.

https://community.bitnami.com/t/problems-with-3-0-1-installation-see-report-inside/30195/

It is not caused on webrick users.

Related:

* rack/rack#732 (comment)
* phusion/passenger#1328
@rafaelfranca
Copy link
Member

Backported as 4df216c

@marutosi marutosi deleted the 4-2-stable-issue-19187 branch April 10, 2015 07:21
@marutosi marutosi restored the 4-2-stable-issue-19187 branch April 10, 2015 07:21
@marutosi marutosi deleted the 4-2-stable-issue-19187 branch April 10, 2015 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
actionpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marutosi @rafaelfranca