TimeZone requires preloading before #freeze #1977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -289,6 +289,12 @@ module ActiveSupport | |||
| Time.now.utc.in_time_zone(self) | |||
| end | |||
|
|
|||
| # Preload information prior to freezing | |||
| def freeze | |||
| tzinfo; utc_offset; | |||
There was a problem hiding this comment.
Better split this line into two, and get rid of the semicolons.
There was a problem hiding this comment.
I'm agree. Can you amend your patch and force-push to your branch?
There was a problem hiding this comment.
Sorry guys, was on vacation. I can certainly do that. I'll get it in today.
'Can't modify frozen object' when calling #freeze after instantiation
|
@sikachu Sorry for the delay. Hope this meets your approval. Thanks again for taking a look at this! |
|
+1 |
|
Not sure about the orignal issue. But what's going on about this PR? |
|
Is this still an issue? |
|
This was previously an issue for me but I haven't been hacking on timezones in a while. I just tried it again and cannot reproduce. I'll close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Can't modify frozen object' when calling #freeze after instantiation
Although I did add tests to this which should have failed, for some reason they didn't. If someone with more knowledge of Rails dependencies could help me out I would appreciate it.
The issue this fixes is here: #1966
There is a 100% repeatable (on the 3 MacBooks I tried) bug wherein executing the following:
And within IRB:
Raises a
Can't modify a frozen objectRuntimeError.Although I can get this error to occur every time, I cannot get it to be reproduced in a test.
I hope this at least puts everyone on the right track to tracking down this problem.