Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset pipeline docs refer to no-longer-working config.assets.cache_store #19835

Closed
jonswar opened this issue Apr 20, 2015 · 6 comments
Closed

Comments

@jonswar
Copy link

jonswar commented Apr 20, 2015

config.assets.cache_store no longer seems to do anything. In my own console:

irb(main):004:0> Rails.application.config.assets.cache_store
=> :memory_store
irb(main):005:0> Rails.application.assets.cache.class
=> Sprockets::Cache::FileStore

and elsewhere on the web:

#10334
http://damon.theidealweb.com/config-assets-cache_store-and-rails-4/

But it is still mentioned as the default way to configure the cache in http://guides.rubyonrails.org/asset_pipeline.html#assets-cache-store

@rafaelfranca
Copy link
Member

cc @zzak

@zzak
Copy link
Member

zzak commented Apr 22, 2015

nfi bro /cc @rafaelfranca @arthurnn

@rafaelfranca
Copy link
Member

Hahaha, you were investigating sprockets related documentation so I thought
you already knew this. I know what needs to be done but I'm almost sure we
will have to rewrite all this guide now with sprockets 3. I'll do that if
you are fine, since I have more background on the matter.

On Wed, Apr 22, 2015, 02:31 Zachary Scott notifications@github.com wrote:

nfi bro /cc @rafaelfranca https://github.com/rafaelfranca @arthurnn
https://github.com/arthurnn


Reply to this email directly or view it on GitHub
#19835 (comment).

@zzak
Copy link
Member

zzak commented Apr 24, 2015

@rafaelfranca Let's collaborate on a new guide for sprockets! <3

prathamesh-sonpatki added a commit to prathamesh-sonpatki/rails that referenced this issue Apr 26, 2015
 - As per rails#19835 (comment)
   assets pipeline guide needs to be rewritten for Sprockets 3.
 - So this commit marks the guide as WIP for now.
@davidbalbert
Copy link
Contributor

@zachallaun and I were working on a related bug and did some poking around before we ran into this issue. I believe this came from a change to sprockets-rails and isn't related to Sprockets 3: We've confirmed that config.assets.cache_store has no effect with sprockets 2.12.4 and sprockets-rails 2.3.2 (the latest sprockets-rails as of this writing). The sprocket-rails README also contains an example of using config.assets.configure to set the cache.

The relevant commit (from 2012) is rails/sprockets-rails@ecaeb27. The commit message refers to rails/sprockets-rails#3, which is an unrelated issue. Given that the repo was moved at some point, my guess is it's probably referring to issue 3 on sstephenson/sprockets-rails, but the issue tracker for that repo has been disabled.

@sstephenson, is there any chance the contents of that issue is still available somewhere? It would be helpful for the related bug that we're looking into. I don't know what happens to an issue when the GitHub issue tracker gets disabled.

@rails-bot
Copy link

This issue has been automatically marked as stale because it has not been commented on for at least
three months.

The resources of the Rails team are limited, and so we are asking for your help.

If you can still reproduce this error on the 4-2-stable, 4-1-stable branches or on master,
please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions.

prathamesh-sonpatki added a commit to prathamesh-sonpatki/rails that referenced this issue Feb 1, 2016
- sprockets-rails no longer supports customizing cache store after
  rails/sprockets-rails@ecaeb27 using `config.assets.cache_store`.
- Instead we need to configure it using block syntax.
- Fixes rails#19835.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants