Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert_file fails when filename has special characters (~, +) #20042

Closed
pravi opened this issue May 6, 2015 · 2 comments · Fixed by #20605
Closed

assert_file fails when filename has special characters (~, +) #20042

pravi opened this issue May 6, 2015 · 2 comments · Fixed by #20605
Assignees
@senny
Labels
railties
Milestone
4.2.3

Comments

@pravi
Copy link

pravi commented May 6, 2015

See sidekiq/sidekiq#2065 for background. These are used to give special meanings to package names in debian (x.y.z~something, means a lower version of x.y.z. this is used to convey ~alpha, ~beta or ~rc should be updated by x.y.z version). I hope this will will be fixed.
@pravi pravi mentioned this issue May 6, 2015
Closed
@senny
Copy link
Member

senny commented May 6, 2015

After a first glimpse I think this is caused by https://github.com/rails/rails/pull/12606/files#diff-790f18b5ff852b81b7b3784b5ce52a79R24

I'll take a look.

@senny senny added the railties label May 6, 2015
@senny senny added this to the 4.2.2 milestone May 6, 2015
@senny senny self-assigned this May 6, 2015
dcrec1 added a commit to dcrec1/rails that referenced this issue Jun 17, 2015
@dcrec1
assert_file understands paths with special characters
4e22bbf 
fixes rails#20042
@dcrec1 dcrec1 mentioned this issue Jun 17, 2015
Merged
dcrec1 added a commit to dcrec1/rails that referenced this issue Jun 18, 2015
@dcrec1
assert_file understands paths with special characters
6074d0f 
fixes rails#20042
@senny
Copy link
Member

senny commented Jun 19, 2015

A fix is merged and backported to 4-2-stable. Will be released with the next non-security 4.2.x release.

@pravi thanks for reporting 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senny senny

Labels
railties
Projects
None yet
Milestone
4.2.3
Development

Successfully merging a pull request may close this issue.

assert_file understands paths with special characters dcrec1/rails
2 participants
@senny @pravi