Properly cache value when it is "false"

[hasclass]

Rails.cache does not properly cache "false", it returns nil instead.

This is because the value is checked with an

if value

...

else
value = nil # => sets false values to nil
end

I changed it to:
if defined?(value)

Example:

Rails.cache.fetch('foo') { false }
=> false # uncached value

Rails.cache.fetch('foo') { false }
=> nil # from cache

[pzac]

Yeah

[sikachu]

Nice catch! 👍

[jamestyj]

Any chance getting this patch into Rails 3.1?

[vijaydev]

@jamestyj This will be available in 3.1.2

[jonleighton]

@vijaydev cherry picking this into 3-1-stable broke the build. the implementation in master has changed since this PR was merged. additionally, the test in this PR actually passes without the fix, so I think even master exhibits this bug still. (also, in the first line of this patch, defined?(value) will always be truthy as it is an argument to the method.)

I am going to revert the cherry-pick for now. I am planning to push 3.1.2rc1 quite soon, but I can wait for a fix for this if you intend to work on it?

[hasclass]

@jonleighton This is fixed in master (by using @value = Marshal.dump(value)).

[vijaydev]

Fixed in cd392fd and passes Travis. Good to go for 3.1.4 :)

[jamestyj]

Finally, thanks!