assert_file understands paths with special characters #20605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@senny is this fix valid? |
| @@ -23,7 +23,7 @@ module Assertions | |||
| # end | |||
| # end | |||
| def assert_file(relative, *contents) | |||
| absolute = File.expand_path(relative, destination_root).shellescape | |||
| absolute = File.expand_path(relative, destination_root).gsub(" ", "\\ ") | |||
There was a problem hiding this comment.
Can you point me in the direction why this gsub is needed?
Given:
$ ls spaces
file with spaces.txt v0.1.4~alpha+nightly
The following script outputs:
path = File.expand_path("../spaces/file with spaces.txt", __FILE__)
path # => /Users/senny/Projects/ruby/spaces/file with spaces.txt
File.exist?(path) # => true
path = File.expand_path("../spaces/v0.1.4~alpha+nightly", __FILE__)
path # => /Users/senny/Projects/ruby/spaces/v0.1.4~alpha+nightly
File.exist?(path) # => true
senny
added a commit
that referenced
this pull request
Jun 19, 2015
assert_file understands paths with special characters
|
Thank you 💛 |
senny
added a commit
that referenced
this pull request
Jun 19, 2015
assert_file understands paths with special characters Conflicts: railties/CHANGELOG.md
y-yagi
added a commit
to y-yagi/rails
that referenced
this pull request
Oct 8, 2015
`shellwords` is no longer needed from rails#20605.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20042