write_cookies! nil exception in ActionDispatch::TestRequest #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen == 'u' on 1.8.7
|
Added a non-implementation specific test this time, and asserted nothing-is-thrown. Seems the problem only happens when $KCODE is set to 'u' on 1.8.7 - so originally I figured I'd put that into the test case, otherwise the failure doesn't get triggered all the time on 1.8.7 (unless that doesn't matter?). |
spastorino
added a commit
that referenced
this pull request
Jul 14, 2011
write_cookies! nil exception in ActionDispatch::TestRequest
|
Please port this to master |
|
It doesn't seem like master has any issues with the nil values (I wrote a test case and it passes, even regardless of the $KCODE setting). Do you want me to just include the test case to avoid any regression? |
|
yes that would be good :) |
spastorino
added a commit
that referenced
this pull request
Jul 14, 2011
ported test from pull request #2071 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write_cookies! in ActionDispatch::TestRequest won't write nil value when $KCODE == 'u' on 1.8.7