#6530 - Plugin install from Github should fail with a message if Git is not installed

[FunkyFortune]

Quick change for https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/6530

Check if svn/git is installed prior to actually installing a plugin.

Not sure how to write a test to cover this...

[andhapp]

Just fixing the link:

https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/6530

[dmathieu]

I also think both commands, which do the same for different tools, should be named similarly.

[sikachu]

I really like this, but I don't think it's ready yet.

• Those ? methods, you can easily make them as alias method. That would be better because I believe it'll be done in C.
• is_ convention, doesn't make sense to have it.
• It would be better if you're detecting which command we need, instead of throwing error that "git/svn etc. is missing"

Do you mind make another patch and rebase your patch? I think that would be nice for 3.2.x

[jeremy]

Bump. Interested in addressing this feedback?

This could use a test, too, demonstrating that the failure is fixed.

[tylercoville]

Where do the tests reside for rails plugin if I am looking at the structure of the tests directory they should reside in /railties/test/application which is where the tests for console, runner, other commands etc. but I can't find any which look like they currently have tests that apply. If one doesn't exist I can make some but don't want to redo something that already exists.

[waseem]

I tried to work on this issue. See waseem@2a1a907 But am not submitting a pull request because I am unable to write tests cases for plugin installation.

I have put a railties/test/application/plugin_test.rb file that will hold tests for plugin installation/removal etcetera.

I was not able to write tests because if you see line#15 of plugin_test.rb, when I try to do bundle exec rails plugin install, test tries to really install the plugin. Is there a way I could stub out Plugin#install_using_#{method} methods?

I also posted a message on core mailing list https://groups.google.com/forum/#!topic/rubyonrails-core/2dm6tb6OcHM but did not get any responses.

[waseem]

This can be closed because of dad7fdc#diff-17

[arunagw]

Closing this