ActiveSupport::Cache::FileStore#file_path_key does not work if initialized with Pathname #2209
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not work if initialized with Pathname
|
i grabbed this failing test commit, fix the issue and made a pull request with the two commits: #2213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you initialize ActiveSupport::Cache::FileStore with a Pathname instance (e.g., Rails.root.join('tmp', 'cache')), #file_path_key does not work correctly--it expects cache_path to be a String, so cache_path.size is the length of the path. When cache_path is a Pathname, cache_path.size is the size of the referenced file or directory on disk.
This appears to have been introduced on 2010-04-27 by commit ee51b51.
See also: