Alias left_joins to left_outer_joins #22125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @sgrif |
sgrif
added a commit
that referenced
this pull request
Oct 30, 2015
Alias left_joins to left_outer_joins
|
Thank you! 💓 |
k0kubun
added a commit
to k0kubun/rails
that referenced
this pull request
Oct 30, 2015
pixeltrix
pushed a commit
that referenced
this pull request
Nov 2, 2015
pixeltrix
added a commit
that referenced
this pull request
Nov 2, 2015
Add CHANGELOG entry for #22125 [ci skip]
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
May 22, 2017
This was added at rails#22125 but `left_joins_values` is never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12071
As I said in #12071 (comment),
left_outer_joinsis slightly long. I really want to use this method withleft_joins. Because OUTER keyword can be abbreviated in an actual query, I think aliasingleft_joinstoleft_outer_joinsis reasonable.